From 9e1db1f9b4f376cd1af8dc2ecd01052dae917220 Mon Sep 17 00:00:00 2001
From: Luna <git@l4.pm>
Date: Tue, 26 Mar 2019 01:02:06 -0300
Subject: [PATCH] test_gateway: add test_heartbeat

 - tests.conftest: hardcode IS_SSL to False
---
 tests/conftest.py       |  1 +
 tests/test_gateway.py   |  2 +-
 tests/test_websocket.py | 35 +++++++++++++++++++++++++++++++++++
 3 files changed, 37 insertions(+), 1 deletion(-)

diff --git a/tests/conftest.py b/tests/conftest.py
index 5917a75..bb8b171 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -39,6 +39,7 @@ def _test_app(unused_tcp_port, event_loop):
     # since the config might give a used one.
     ws_port = unused_tcp_port
 
+    main_app.config['IS_SSL'] = False
     main_app.config['WS_PORT'] = ws_port
     main_app.config['WEBSOCKET_URL'] = f'localhost:{ws_port}'
 
diff --git a/tests/test_gateway.py b/tests/test_gateway.py
index 57b787d..e18d8e4 100644
--- a/tests/test_gateway.py
+++ b/tests/test_gateway.py
@@ -28,7 +28,7 @@ from tests.common import login
 
 @pytest.mark.asyncio
 async def test_gw(test_cli):
-    """Test if the gateway route is sane."""
+    """Test if the gateway route works."""
     resp = await test_cli.get('/api/v6/gateway')
     assert resp.status_code == 200
     rjson = await resp.json
diff --git a/tests/test_websocket.py b/tests/test_websocket.py
index b251ad9..757e07e 100644
--- a/tests/test_websocket.py
+++ b/tests/test_websocket.py
@@ -35,6 +35,13 @@ async def _json_send(conn, data):
     await conn.send(frame)
 
 
+async def _json_send_op(conn, opcode, data=None):
+    await _json_send(conn, {
+        'op': opcode,
+        'd': data
+    })
+
+
 async def get_gw(test_cli) -> str:
     """Get the Gateway URL."""
     gw_resp = await test_cli.get('/api/v6/gateway')
@@ -122,3 +129,31 @@ async def test_ready_fields(test_cli):
     assert isinstance(data['session_id'], str)
 
     await conn.close(1000, 'test end')
+
+
+@pytest.mark.asyncio
+async def test_heartbeat(test_cli):
+    token = await login('normal', test_cli)
+    conn = await gw_start(test_cli)
+
+    # get the hello frame but ignore it
+    await _json(conn)
+
+    await _json_send(conn, {
+        'op': OP.IDENTIFY,
+        'd': {
+            'token': token,
+        }
+    })
+
+    # ignore ready data
+    ready = await _json(conn)
+    assert isinstance(ready, dict)
+    assert ready['op'] == OP.DISPATCH
+    assert ready['t'] == 'READY'
+
+    # test a heartbeat
+    await _json_send_op(conn, OP.HEARTBEAT)
+    recv = await _json(conn)
+    assert isinstance(recv, dict)
+    assert recv['op'] == OP.HEARTBEAT_ACK